Commit 907ed123 authored by Dan Carpenter's avatar Dan Carpenter Committed by Viresh Kumar
Browse files

OPP: call of_node_put() on error path in _bandwidth_supported() 



This code does not call of_node_put(opp_np) if of_get_next_available_child()
returns NULL.  But it should.

Fixes: 45679f9b ("opp: Don't parse icc paths unnecessarily")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent 31231092

drivers/opp/of.c

+1 −1
Original line number Diff line number Diff line
@@ -437,11 +437,11 @@ static int _bandwidth_supported(struct device *dev, struct opp_table *opp_table) 


	/* Checking only first OPP is sufficient */

	np = of_get_next_available_child(opp_np, NULL);

	of_node_put(opp_np);

	if (!np) {

		dev_err(dev, "OPP table empty\n");

		return -EINVAL;

	}

	of_node_put(opp_np);



	prop = of_find_property(np, "opp-peak-kBps", NULL);

	of_node_put(np);