Commit 9076bc47 authored by Jinjie Ruan's avatar Jinjie Ruan Committed by Shuah Khan
Browse files

kunit: Fix possible memory leak in kunit_filter_suites() 



If both filter_glob and filters are not NULL, and kunit_parse_glob_filter()
succeed, but kcalloc parsed_filters fails, the suite_glob and test_glob of
parsed kzalloc in kunit_parse_glob_filter() will be leaked.

As Rae suggested, assign -ENOMEM to *err to correctly free copy and goto
free_parsed_glob to free the suite/test_glob of parsed.

Fixes: 1c9fd080 ("kunit: fix uninitialized variables bug in attributes filtering")
Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
Suggested-by: default avatarRae Moar <rmoar@google.com>
Reviewed-by: default avatarDavid Gow <davidgow@google.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent 2b56a4b7

lib/kunit/executor.c

+2 −2
Original line number Diff line number Diff line
@@ -175,8 +175,8 @@ kunit_filter_suites(const struct kunit_suite_set *suite_set, 
		filter_count = kunit_get_filter_count(filters);

		parsed_filters = kcalloc(filter_count, sizeof(*parsed_filters), GFP_KERNEL);

		if (!parsed_filters) {

			kfree(copy);

			return filtered;

			*err = -ENOMEM;

			goto free_parsed_glob;

		}

		for (j = 0; j < filter_count; j++)

			parsed_filters[j] = kunit_next_attr_filter(&filters, err);