Commit 8ff38e73 authored by Moshe Shemesh's avatar Moshe Shemesh Committed by Jakub Kicinski
Browse files

net/mlx5: Stop waiting for PCI up if teardown was triggered 



If driver teardown is called while PCI is turned off, there is a race
between health recovery and teardown. If health recovery already started
it will wait 60 sec trying to see if PCI gets back and it can recover,
but actually there is no need to wait anymore once teardown was called.

Use the MLX5_BREAK_FW_WAIT flag which is set on driver teardown to break
waiting for PCI up.

Signed-off-by: default avatarMoshe Shemesh <moshe@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
Link: https://lore.kernel.org/r/20230314054234.267365-3-saeed@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c05d145a

drivers/net/ethernet/mellanox/mlx5/core/health.c

+4 −0
Original line number Diff line number Diff line
@@ -325,6 +325,10 @@ int mlx5_health_wait_pci_up(struct mlx5_core_dev *dev) 
	while (sensor_pci_not_working(dev)) {

		if (time_after(jiffies, end))

			return -ETIMEDOUT;

		if (test_bit(MLX5_BREAK_FW_WAIT, &dev->intf_state)) {

			mlx5_core_warn(dev, "device is being removed, stop waiting for PCI\n");

			return -ENODEV;

		}

		msleep(100);

	}

	return 0;