Commit 8fd91151 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Herbert Xu
Browse files

crypto: sun8i-ss - Fix a test in sun8i_ss_setup_ivs() 



SS_ENCRYPTION is (0 << 7 = 0), so the test can never be true.
Use a direct comparison to SS_ENCRYPTION instead.

The same king of test is already done the same way in sun8i_ss_run_task().

Fixes: 359e893e ("crypto: sun8i-ss - rework handling of IV")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 482c84e9

drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c

+1 −1
Original line number Diff line number Diff line
@@ -151,7 +151,7 @@ static int sun8i_ss_setup_ivs(struct skcipher_request *areq) 
		}

		rctx->p_iv[i] = a;

		/* we need to setup all others IVs only in the decrypt way */

		if (rctx->op_dir & SS_ENCRYPTION)

		if (rctx->op_dir == SS_ENCRYPTION)

			return 0;

		todo = min(len, sg_dma_len(sg));

		len -= todo;