Commit 8fc5d433 authored by Po-Hao Huang's avatar Po-Hao Huang Committed by Kalle Valo
Browse files

wifi: rtw89: fix unsuccessful interface_add flow 



Remove according vifs from list if we couldn't set this interface up.
Otherwise the rtwvif_list could contain unreferenced objects.

Signed-off-by: default avatarPo-Hao Huang <phhuang@realtek.com>
Signed-off-by: default avatarPing-Ke Shih <pkshih@realtek.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20221202061527.505668-4-pkshih@realtek.com
parent d592b9f7

drivers/net/wireless/realtek/rtw89/mac80211.c

+2 −0
Original line number Diff line number Diff line
@@ -125,6 +125,7 @@ static int rtw89_ops_add_interface(struct ieee80211_hw *hw, 
						  RTW89_PORT_NUM);

	if (rtwvif->port == RTW89_PORT_NUM) {

		ret = -ENOSPC;

		list_del_init(&rtwvif->list);

		goto out;

	}
@@ -138,6 +139,7 @@ static int rtw89_ops_add_interface(struct ieee80211_hw *hw, 
	ret = rtw89_mac_add_vif(rtwdev, rtwvif);

	if (ret) {

		rtw89_core_release_bit_map(rtwdev->hw_port, rtwvif->port);

		list_del_init(&rtwvif->list);

		goto out;

	}