Commit 8fc37ec5 authored by Al Viro's avatar Al Viro
Browse files

don't expose I_NEW inodes via dentry->d_inode 



	d_instantiate(dentry, inode);
	unlock_new_inode(inode);

is a bad idea; do it the other way round...

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 32a7991b

fs/ecryptfs/inode.c

+1 −1
Original line number Diff line number Diff line
@@ -269,8 +269,8 @@ ecryptfs_create(struct inode *directory_inode, struct dentry *ecryptfs_dentry, 
		iput(ecryptfs_inode);

		goto out;

	}

	d_instantiate(ecryptfs_dentry, ecryptfs_inode);

	unlock_new_inode(ecryptfs_inode);

	d_instantiate(ecryptfs_dentry, ecryptfs_inode);

out:

	return rc;

}

fs/ext2/namei.c

+2 −2
Original line number Diff line number Diff line
@@ -41,8 +41,8 @@ static inline int ext2_add_nondir(struct dentry *dentry, struct inode *inode) 
{

	int err = ext2_add_link(dentry, inode);

	if (!err) {

		d_instantiate(dentry, inode);

		unlock_new_inode(inode);

		d_instantiate(dentry, inode);

		return 0;

	}

	inode_dec_link_count(inode);
@@ -242,8 +242,8 @@ static int ext2_mkdir(struct inode * dir, struct dentry * dentry, umode_t mode) 
	if (err)

		goto out_fail;



	d_instantiate(dentry, inode);

	unlock_new_inode(inode);

	d_instantiate(dentry, inode);

out:

	return err;

fs/ext3/namei.c

+2 −2
Original line number Diff line number Diff line
@@ -1671,8 +1671,8 @@ static int ext3_add_nondir(handle_t *handle, 
	int err = ext3_add_entry(handle, dentry, inode);

	if (!err) {

		ext3_mark_inode_dirty(handle, inode);

		d_instantiate(dentry, inode);

		unlock_new_inode(inode);

		d_instantiate(dentry, inode);

		return 0;

	}

	drop_nlink(inode);
@@ -1836,8 +1836,8 @@ static int ext3_mkdir(struct inode * dir, struct dentry * dentry, umode_t mode) 
	if (err)

		goto out_clear_inode;



	d_instantiate(dentry, inode);

	unlock_new_inode(inode);

	d_instantiate(dentry, inode);

out_stop:

	brelse(dir_block);

	ext3_journal_stop(handle);

fs/ext4/namei.c

+2 −2
Original line number Diff line number Diff line
@@ -2072,8 +2072,8 @@ static int ext4_add_nondir(handle_t *handle, 
	int err = ext4_add_entry(handle, dentry, inode);

	if (!err) {

		ext4_mark_inode_dirty(handle, inode);

		d_instantiate(dentry, inode);

		unlock_new_inode(inode);

		d_instantiate(dentry, inode);

		return 0;

	}

	drop_nlink(inode);
@@ -2249,8 +2249,8 @@ static int ext4_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 
	err = ext4_mark_inode_dirty(handle, dir);

	if (err)

		goto out_clear_inode;

	d_instantiate(dentry, inode);

	unlock_new_inode(inode);

	d_instantiate(dentry, inode);

out_stop:

	brelse(dir_block);

	ext4_journal_stop(handle);

fs/jffs2/dir.c

+4 −4
Original line number Diff line number Diff line
@@ -226,8 +226,8 @@ static int jffs2_create(struct inode *dir_i, struct dentry *dentry, 
		  __func__, inode->i_ino, inode->i_mode, inode->i_nlink,

		  f->inocache->pino_nlink, inode->i_mapping->nrpages);



	d_instantiate(dentry, inode);

	unlock_new_inode(inode);

	d_instantiate(dentry, inode);

	return 0;



 fail:
@@ -446,8 +446,8 @@ static int jffs2_symlink (struct inode *dir_i, struct dentry *dentry, const char 
	mutex_unlock(&dir_f->sem);

	jffs2_complete_reservation(c);



	d_instantiate(dentry, inode);

	unlock_new_inode(inode);

	d_instantiate(dentry, inode);

	return 0;



 fail:
@@ -591,8 +591,8 @@ static int jffs2_mkdir (struct inode *dir_i, struct dentry *dentry, umode_t mode 
	mutex_unlock(&dir_f->sem);

	jffs2_complete_reservation(c);



	d_instantiate(dentry, inode);

	unlock_new_inode(inode);

	d_instantiate(dentry, inode);

	return 0;



 fail:
@@ -766,8 +766,8 @@ static int jffs2_mknod (struct inode *dir_i, struct dentry *dentry, umode_t mode 
	mutex_unlock(&dir_f->sem);

	jffs2_complete_reservation(c);



	d_instantiate(dentry, inode);

	unlock_new_inode(inode);

	d_instantiate(dentry, inode);

	return 0;



 fail: