Commit 8facae29 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Jonathan Cameron
Browse files

iio: amplifiers: hmc425a: Simplify with dev_err_probe() 



Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20200829064726.26268-10-krzk@kernel.org


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent bfa96be8

drivers/iio/amplifiers/hmc425a.c

+3 −6
Original line number Diff line number Diff line
@@ -201,12 +201,9 @@ static int hmc425a_probe(struct platform_device *pdev) 
	st->gain = st->chip_info->default_gain;



	st->gpios = devm_gpiod_get_array(&pdev->dev, "ctrl", GPIOD_OUT_LOW);

	if (IS_ERR(st->gpios)) {

		ret = PTR_ERR(st->gpios);

		if (ret != -EPROBE_DEFER)

			dev_err(&pdev->dev, "failed to get gpios\n");

		return ret;

	}

	if (IS_ERR(st->gpios))

		return dev_err_probe(&pdev->dev, PTR_ERR(st->gpios),

				     "failed to get gpios\n");



	if (st->gpios->ndescs != st->chip_info->num_gpios) {

		dev_err(&pdev->dev, "%d GPIOs needed to operate\n",