Commit 8fac27fb authored by Jakub Kicinski's avatar Jakub Kicinski Committed by Kalle Valo
Browse files

wireless: use eth_hw_addr_set() for dev->addr_len cases 



Convert all WiFi drivers from memcpy(... dev->addr_len)
to eth_hw_addr_set():

  @@
  expression dev, np;
  @@
  - memcpy(dev->dev_addr, np, dev->addr_len)
  + eth_hw_addr_set(dev, np)

Manually checked the netdevs are allocated with alloc_etherdev(),
so dev->addr_len must be equal to ETH_ALEN.

Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20211018235021.1279697-4-kuba@kernel.org
parent fcb79f31

drivers/net/wireless/atmel/atmel.c

+1 −1
Original line number Diff line number Diff line
@@ -1296,7 +1296,7 @@ static int atmel_set_mac_address(struct net_device *dev, void *p) 
{

	struct sockaddr *addr = p;



	memcpy (dev->dev_addr, addr->sa_data, dev->addr_len);

	eth_hw_addr_set(dev, addr->sa_data);

	return atmel_open(dev);

}

drivers/net/wireless/zydas/zd1201.c

+1 −1
Original line number Diff line number Diff line
@@ -857,7 +857,7 @@ static int zd1201_set_mac_address(struct net_device *dev, void *p) 
	    addr->sa_data, dev->addr_len, 1);

	if (err)

		return err;

	memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);

	eth_hw_addr_set(dev, addr->sa_data);



	return zd1201_mac_reset(zd);

}