Commit 8f9850dd authored by Dan Carpenter's avatar Dan Carpenter Committed by Paolo Abeni
Browse files

net: phy: unlock on error in phy_probe() 



If genphy_c45_read_eee_adv() fails then we need to do a reset and unlock
the &phydev->lock mutex before returning.

Fixes: 3eeca4e1 ("net: phy: do not force EEE support")
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Reviewed-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
Link: https://lore.kernel.org/r/Y/x/6kHCjnQHqOpF@kili


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 11f180a5

drivers/net/phy/phy_device.c

+1 −1
Original line number Diff line number Diff line
@@ -3146,7 +3146,7 @@ static int phy_probe(struct device *dev) 
	 */

	err = genphy_c45_read_eee_adv(phydev, phydev->advertising_eee);

	if (err)

		return err;

		goto out;



	/* There is no "enabled" flag. If PHY is advertising, assume it is

	 * kind of enabled.