Commit 8f8033d5 authored by Rafael Mendonca's avatar Rafael Mendonca Committed by Alex Deucher
Browse files

drm/amdgpu/powerplay/psm: Fix memory leak in power state init 



Commit 902bc65d ("drm/amdgpu/powerplay/psm: return an error in power
state init") made the power state init function return early in case of
failure to get an entry from the powerplay table, but it missed to clean up
the allocated memory for the current power state before returning.

Fixes: 902bc65d ("drm/amdgpu/powerplay/psm: return an error in power state init")
Reviewed-by: default avatarEvan Quan <evan.quan@amd.com>
Signed-off-by: default avatarRafael Mendonca <rafaelmendsr@gmail.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent df768a97

drivers/gpu/drm/amd/pm/powerplay/hwmgr/pp_psm.c

+2 −0
Original line number Diff line number Diff line
@@ -75,8 +75,10 @@ int psm_init_power_state_table(struct pp_hwmgr *hwmgr) 
	for (i = 0; i < table_entries; i++) {

		result = hwmgr->hwmgr_func->get_pp_table_entry(hwmgr, i, state);

		if (result) {

			kfree(hwmgr->current_ps);

			kfree(hwmgr->request_ps);

			kfree(hwmgr->ps);

			hwmgr->current_ps = NULL;

			hwmgr->request_ps = NULL;

			hwmgr->ps = NULL;

			return -EINVAL;