Commit 8f662cd9 authored by Johan Hovold's avatar Johan Hovold Committed by Vinod Koul
Browse files

phy: qcom-qmp-pcie: drop obsolete pipe clock type check 



Drop the obsolete pipe clock handling which was used to treat the pipe
clock as optional for types other than PCIe and USB and which is no
longer needed since splitting the PHY driver.

Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20220623113314.29761-2-johan+linaro@kernel.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 6a23afad

drivers/phy/qualcomm/phy-qcom-qmp-pcie.c

+2 −17
Original line number Diff line number Diff line
@@ -2210,26 +2210,11 @@ int qcom_qmp_phy_pcie_create(struct device *dev, struct device_node *np, int id, 
	if (!qphy->pcs_misc)

		dev_vdbg(dev, "PHY pcs_misc-reg not used\n");



	/*

	 * Get PHY's Pipe clock, if any. USB3 and PCIe are PIPE3

	 * based phys, so they essentially have pipe clock. So,

	 * we return error in case phy is USB3 or PIPE type.

	 * Otherwise, we initialize pipe clock to NULL for

	 * all phys that don't need this.

	 */

	snprintf(prop_name, sizeof(prop_name), "pipe%d", id);

	qphy->pipe_clk = devm_get_clk_from_child(dev, np, prop_name);

	if (IS_ERR(qphy->pipe_clk)) {

		if (cfg->type == PHY_TYPE_PCIE ||

		    cfg->type == PHY_TYPE_USB3) {

			ret = PTR_ERR(qphy->pipe_clk);

			if (ret != -EPROBE_DEFER)

				dev_err(dev,

					"failed to get lane%d pipe_clk, %d\n",

					id, ret);

			return ret;

		}

		qphy->pipe_clk = NULL;

		return dev_err_probe(dev, PTR_ERR(qphy->pipe_clk),

				     "failed to get lane%d pipe clock\n", id);

	}



	generic_phy = devm_phy_create(dev, np, &qcom_qmp_phy_pcie_ops);