Commit 8f486cab authored by Saravana Kannan's avatar Saravana Kannan Committed by Greg Kroah-Hartman
Browse files

driver core: fw_devlink: Allow firmware to mark devices as best effort 



When firmware sets the FWNODE_FLAG_BEST_EFFORT flag for a fwnode,
fw_devlink will do a best effort ordering for that device where it'll
only enforce the probe/suspend/resume ordering of that device with
suppliers that have drivers. The driver of that device can then decide
if it wants to defer probe or probe without the suppliers.

This will be useful for avoid probe delays of the console device that
were caused by commit 71066545 ("driver core: Set
fw_devlink.strict=1 by default").

Fixes: 71066545 ("driver core: Set fw_devlink.strict=1 by default")
Reported-by: default avatarSascha Hauer <sha@pengutronix.de>
Reported-by: default avatarPeng Fan <peng.fan@nxp.com>
Tested-by: default avatarPeng Fan <peng.fan@nxp.com>
Signed-off-by: default avatarSaravana Kannan <saravanak@google.com>
Link: https://lore.kernel.org/r/20220623080344.783549-2-saravanak@google.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1d25b84e

drivers/base/core.c

+2 −1
Original line number Diff line number Diff line
@@ -968,7 +968,8 @@ static void device_links_missing_supplier(struct device *dev) 


static bool dev_is_best_effort(struct device *dev)

{

	return fw_devlink_best_effort && dev->can_match;

	return (fw_devlink_best_effort && dev->can_match) ||

		(dev->fwnode && (dev->fwnode->flags & FWNODE_FLAG_BEST_EFFORT));

}



/**

include/linux/fwnode.h

+4 −0
Original line number Diff line number Diff line
@@ -27,11 +27,15 @@ struct device; 
 *			     driver needs its child devices to be bound with

 *			     their respective drivers as soon as they are

 *			     added.

 * BEST_EFFORT: The fwnode/device needs to probe early and might be missing some

 *		suppliers. Only enforce ordering with suppliers that have

 *		drivers.

 */

#define FWNODE_FLAG_LINKS_ADDED			BIT(0)

#define FWNODE_FLAG_NOT_DEVICE			BIT(1)

#define FWNODE_FLAG_INITIALIZED			BIT(2)

#define FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD	BIT(3)

#define FWNODE_FLAG_BEST_EFFORT			BIT(4)



struct fwnode_handle {

	struct fwnode_handle *secondary;