Commit 8f3f330d authored by Jason Wang's avatar Jason Wang Committed by David S. Miller
Browse files

tun: add missing rcu annotation in tun_set_ebpf() 



We expecte prog_p to be protected by rcu, so adding the rcu annotation
to fix the following sparse warning:

drivers/net/tun.c:3003:36: warning: incorrect type in argument 2 (different address spaces)
drivers/net/tun.c:3003:36:    expected struct tun_prog [noderef] __rcu **prog_p
drivers/net/tun.c:3003:36:    got struct tun_prog **prog_p
drivers/net/tun.c:3292:42: warning: incorrect type in argument 2 (different address spaces)
drivers/net/tun.c:3292:42:    expected struct tun_prog **prog_p
drivers/net/tun.c:3292:42:    got struct tun_prog [noderef] __rcu **
drivers/net/tun.c:3296:42: warning: incorrect type in argument 2 (different address spaces)
drivers/net/tun.c:3296:42:    expected struct tun_prog **prog_p
drivers/net/tun.c:3296:42:    got struct tun_prog [noderef] __rcu **

Reported-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 48040793

drivers/net/tun.c

+1 −1
Original line number Diff line number Diff line
@@ -2983,7 +2983,7 @@ static int tun_set_queue(struct file *file, struct ifreq *ifr) 
	return ret;

}



static int tun_set_ebpf(struct tun_struct *tun, struct tun_prog **prog_p,

static int tun_set_ebpf(struct tun_struct *tun, struct tun_prog __rcu **prog_p,

			void __user *data)

{

	struct bpf_prog *prog;