Commit 8f3a6de3 authored by Pavel Emelyanov's avatar Pavel Emelyanov Committed by J. Bruce Fields
Browse files

sunrpc: Turn list_for_each-s into the ..._entry-s 



Saves some lines of code and some branticks when reading one.

Signed-off-by: default avatarPavel Emelyanov <xemul@openvz.org>
Reviewed-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 50fa0d40

net/sunrpc/svc_xprt.c

+2 −4
Original line number Diff line number Diff line
@@ -100,16 +100,14 @@ EXPORT_SYMBOL_GPL(svc_unreg_xprt_class); 
 */

int svc_print_xprts(char *buf, int maxlen)

{

	struct list_head *le;

	struct svc_xprt_class *xcl;

	char tmpstr[80];

	int len = 0;

	buf[0] = '\0';



	spin_lock(&svc_xprt_class_lock);

	list_for_each(le, &svc_xprt_class_list) {

	list_for_each_entry(xcl, &svc_xprt_class_list, xcl_list) {

		int slen;

		struct svc_xprt_class *xcl =

			list_entry(le, struct svc_xprt_class, xcl_list);



		sprintf(tmpstr, "%s %d\n", xcl->xcl_name, xcl->xcl_max_payload);

		slen = strlen(tmpstr);

net/sunrpc/svcsock.c

+3 −9
Original line number Diff line number Diff line
@@ -1261,19 +1261,13 @@ void svc_sock_update_bufs(struct svc_serv *serv) 
	 * The number of server threads has changed. Update

	 * rcvbuf and sndbuf accordingly on all sockets

	 */

	struct list_head *le;

	struct svc_sock *svsk;



	spin_lock_bh(&serv->sv_lock);

	list_for_each(le, &serv->sv_permsocks) {

		struct svc_sock *svsk =

			list_entry(le, struct svc_sock, sk_xprt.xpt_list);

	list_for_each_entry(svsk, &serv->sv_permsocks, sk_xprt.xpt_list)

		set_bit(XPT_CHNGBUF, &svsk->sk_xprt.xpt_flags);

	}

	list_for_each(le, &serv->sv_tempsocks) {

		struct svc_sock *svsk =

			list_entry(le, struct svc_sock, sk_xprt.xpt_list);

	list_for_each_entry(svsk, &serv->sv_tempsocks, sk_xprt.xpt_list)

		set_bit(XPT_CHNGBUF, &svsk->sk_xprt.xpt_flags);

	}

	spin_unlock_bh(&serv->sv_lock);

}

EXPORT_SYMBOL_GPL(svc_sock_update_bufs);

net/sunrpc/xprt.c

+2 −4
Original line number Diff line number Diff line
@@ -755,13 +755,11 @@ static void xprt_connect_status(struct rpc_task *task) 
 */

struct rpc_rqst *xprt_lookup_rqst(struct rpc_xprt *xprt, __be32 xid)

{

	struct list_head *pos;

	struct rpc_rqst *entry;



	list_for_each(pos, &xprt->recv) {

		struct rpc_rqst *entry = list_entry(pos, struct rpc_rqst, rq_list);

	list_for_each_entry(entry, &xprt->recv, rq_list)

		if (entry->rq_xid == xid)

			return entry;

	}



	dprintk("RPC:       xprt_lookup_rqst did not find xid %08x\n",

			ntohl(xid));