Commit 8f2ca70c authored by Oz Shlomo's avatar Oz Shlomo Committed by Paolo Abeni
Browse files

net/sched: optimize action stats api calls 



Currently the hw action stats update is called from tcf_exts_hw_stats_update,
when a tc filter is dumped, and from tcf_action_copy_stats, when a hw
action is dumped.
However, the tcf_action_copy_stats is also called from tcf_action_dump.
As such, the hw action stats update cb is called 3 times for every
tc flower filter dump.

Move the tc action hw stats update from tcf_action_copy_stats to
tcf_dump_walker to update the hw action stats when tc action is dumped.

Signed-off-by: default avatarOz Shlomo <ozsh@nvidia.com>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Reviewed-by: default avatarMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: default avatarJamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent a71fad0f

net/sched/act_api.c

+2 −3
Original line number Diff line number Diff line
@@ -539,6 +539,8 @@ static int tcf_dump_walker(struct tcf_idrinfo *idrinfo, struct sk_buff *skb, 
			       (unsigned long)p->tcfa_tm.lastuse))

			continue;



		tcf_action_update_hw_stats(p);



		nest = nla_nest_start_noflag(skb, n_i);

		if (!nest) {

			index--;
@@ -1539,9 +1541,6 @@ int tcf_action_copy_stats(struct sk_buff *skb, struct tc_action *p, 
	if (p == NULL)

		goto errout;



	/* update hw stats for this action */

	tcf_action_update_hw_stats(p);



	/* compat_mode being true specifies a call that is supposed

	 * to add additional backward compatibility statistic TLVs.

	 */