Commit 8f269102 authored by Joakim Zhang's avatar Joakim Zhang Committed by David S. Miller
Browse files

net: stmmac: disable clocks in stmmac_remove_config_dt() 



Platform drivers may call stmmac_probe_config_dt() to parse dt, could
call stmmac_remove_config_dt() in error handing after dt parsed, so need
disable clocks in stmmac_remove_config_dt().

Go through all platforms drivers which use stmmac_probe_config_dt(),
none of them disable clocks manually, so it's safe to disable them in
stmmac_remove_config_dt().

Fixes: commit d2ed0a77 ("net: ethernet: stmmac: fix of-node and fixed-link-phydev leaks")
Signed-off-by: default avatarJoakim Zhang <qiangqing.zhang@nxp.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a4f0377d

drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c

+2 −0
Original line number Diff line number Diff line
@@ -622,6 +622,8 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac) 
void stmmac_remove_config_dt(struct platform_device *pdev,

			     struct plat_stmmacenet_data *plat)

{

	clk_disable_unprepare(plat->stmmac_clk);

	clk_disable_unprepare(plat->pclk);

	of_node_put(plat->phy_node);

	of_node_put(plat->mdio_node);

}