Unverified Commit 8f1c517c authored by Rob Herring's avatar Rob Herring Committed by Krzysztof Wilczyński
Browse files

PCI: iproc: Use of_property_read_bool() for boolean properties 

Replace low-level property access functions like of_get_property() and
of_find_property() with their typed equivalents (i.e., of_property_read_<type>
functions), as it's preferred to use typed property access functions for
reading properties.

[kwilczynski: commit log]
Link: https://lore.kernel.org/linux-pci/20230609193326.1963542-1-robh@kernel.org


Signed-off-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Acked-by: default avatarRay Jui <ray.jui@broadcom.com>
parent 06c2afb8

drivers/pci/controller/pcie-iproc-msi.c

+2 −3
Original line number Diff line number Diff line
@@ -525,7 +525,7 @@ int iproc_msi_init(struct iproc_pcie *pcie, struct device_node *node) 
	if (!of_device_is_compatible(node, "brcm,iproc-msi"))

		return -ENODEV;



	if (!of_find_property(node, "msi-controller", NULL))

	if (!of_property_read_bool(node, "msi-controller"))

		return -ENODEV;



	if (pcie->msi)
@@ -585,8 +585,7 @@ int iproc_msi_init(struct iproc_pcie *pcie, struct device_node *node) 
		return -EINVAL;

	}



	if (of_find_property(node, "brcm,pcie-msi-inten", NULL))

		msi->has_inten_reg = true;

	msi->has_inten_reg = of_property_read_bool(node, "brcm,pcie-msi-inten");



	msi->nr_msi_vecs = msi->nr_irqs * EQ_LEN;

	msi->bitmap = devm_bitmap_zalloc(pcie->dev, msi->nr_msi_vecs,