Commit 8f13142a authored by Colin Ian King's avatar Colin Ian King Committed by Martin K. Petersen
Browse files

scsi: target: Remove redundant assignment to variable ret 

The variable ret is being initialized with a value that is never read, the
assignment is redundant and can be removed.

Link: https://lore.kernel.org/r/20210721101519.42299-1-colin.king@canonical.com


Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Addresses-Coverity: ("Unused value")
parent ff2d86d0

drivers/target/iscsi/cxgbit/cxgbit_ddp.c

+1 −1
Original line number Diff line number Diff line
@@ -234,7 +234,7 @@ cxgbit_get_r2t_ttt(struct iscsi_conn *conn, struct iscsi_cmd *cmd, 
	struct cxgbit_device *cdev = csk->com.cdev;

	struct cxgbit_cmd *ccmd = iscsit_priv_cmd(cmd);

	struct cxgbi_task_tag_info *ttinfo = &ccmd->ttinfo;

	int ret = -EINVAL;

	int ret;



	if ((!ccmd->setup_ddp) ||

	    (!test_bit(CSK_DDP_ENABLE, &csk->com.flags)))

drivers/target/loopback/tcm_loop.c

+2 −2
Original line number Diff line number Diff line
@@ -241,7 +241,7 @@ static int tcm_loop_abort_task(struct scsi_cmnd *sc) 
{

	struct tcm_loop_hba *tl_hba;

	struct tcm_loop_tpg *tl_tpg;

	int ret = FAILED;

	int ret;



	/*

	 * Locate the tcm_loop_hba_t pointer
@@ -261,7 +261,7 @@ static int tcm_loop_device_reset(struct scsi_cmnd *sc) 
{

	struct tcm_loop_hba *tl_hba;

	struct tcm_loop_tpg *tl_tpg;

	int ret = FAILED;

	int ret;



	/*

	 * Locate the tcm_loop_hba_t pointer

drivers/target/target_core_iblock.c

+1 −1
Original line number Diff line number Diff line
@@ -83,7 +83,7 @@ static int iblock_configure_device(struct se_device *dev) 
	struct blk_integrity *bi;

	fmode_t mode;

	unsigned int max_write_zeroes_sectors;

	int ret = -ENOMEM;

	int ret;



	if (!(ib_dev->ibd_flags & IBDF_HAS_UDEV_PATH)) {

		pr_err("Missing udev_path= parameters for IBLOCK\n");