Commit 8efcbe92 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Daniel Lezcano
Browse files

clocksource/drivers/timer-ti-dm: Improve error message in .remove 



If a platform driver's remove callback returns an error code, the driver
core emits a generic (and thus little helpful) error message.

Instead emit a more specifc error message about the actual error and
return zero to suppress the core's message.

Note that returning zero has no side effects apart from not emitting
said error message. This prepares converting platform driver's remove
message to return void.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230313075430.2730803-4-u.kleine-koenig@pengutronix.de
parent ede38f92

drivers/clocksource/timer-ti-dm.c

+4 −1
Original line number Original line Diff line number Diff line
@@ -1197,7 +1197,10 @@ static int omap_dm_timer_remove(struct platform_device *pdev) 




	pm_runtime_disable(&pdev->dev);

	pm_runtime_disable(&pdev->dev);





	return ret;

	if (ret)

		dev_err(&pdev->dev, "Unable to determine timer entry in list of drivers on remove\n");



	return 0;

}

}





static const struct omap_dm_timer_ops dmtimer_ops = {

static const struct omap_dm_timer_ops dmtimer_ops = {