Commit 8ef85999 authored by Liu Shixin's avatar Liu Shixin Committed by Jens Axboe
Browse files

block: aoe: use DEFINE_SHOW_ATTRIBUTE to simplify aoe_debugfs 



Use DEFINE_SHOW_ATTRIBUTE helper macro to simplify the code.

Signed-off-by: default avatarLiu Shixin <liushixin2@huawei.com>
Link: https://lore.kernel.org/r/20220915023424.3198940-1-liushixin2@huawei.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent e55e1b48

drivers/block/aoe/aoeblk.c

+2 −13
Original line number Diff line number Diff line
@@ -108,7 +108,7 @@ static ssize_t aoedisk_show_payload(struct device *dev, 
	return sysfs_emit(page, "%lu\n", d->maxbcnt);

}



static int aoedisk_debugfs_show(struct seq_file *s, void *ignored)

static int aoe_debugfs_show(struct seq_file *s, void *ignored)

{

	struct aoedev *d;

	struct aoetgt **t, **te;
@@ -151,11 +151,7 @@ static int aoedisk_debugfs_show(struct seq_file *s, void *ignored) 


	return 0;

}



static int aoe_debugfs_open(struct inode *inode, struct file *file)

{

	return single_open(file, aoedisk_debugfs_show, inode->i_private);

}

DEFINE_SHOW_ATTRIBUTE(aoe_debugfs);



static DEVICE_ATTR(state, 0444, aoedisk_show_state, NULL);

static DEVICE_ATTR(mac, 0444, aoedisk_show_mac, NULL);
@@ -184,13 +180,6 @@ static const struct attribute_group *aoe_attr_groups[] = { 
	NULL,

};



static const struct file_operations aoe_debugfs_fops = {

	.open = aoe_debugfs_open,

	.read = seq_read,

	.llseek = seq_lseek,

	.release = single_release,

};



static void

aoedisk_add_debugfs(struct aoedev *d)

{