Commit 8ee1c0f6 authored by Biju Das's avatar Biju Das Committed by Daniel Lezcano
Browse files

thermal/drivers/rz2gl: Add error check for reset_control_deassert() 



If reset_control_deassert() fails, then we won't be able to access
the device registers. Therefore check the return code of
reset_control_deassert() and bail out in case of error.

While at it replace the parameter "&pdev->dev" -> "dev" in
devm_reset_control_get_exclusive().

Suggested-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: default avatarBiju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Link: https://lore.kernel.org/r/20211208164010.4130-1-biju.das.jz@bp.renesas.com


Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
parent 3de89d88

drivers/thermal/rzg2l_thermal.c

+4 −2
Original line number Diff line number Diff line
@@ -170,12 +170,14 @@ static int rzg2l_thermal_probe(struct platform_device *pdev) 
		return PTR_ERR(priv->base);



	priv->dev = dev;

	priv->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);

	priv->rstc = devm_reset_control_get_exclusive(dev, NULL);

	if (IS_ERR(priv->rstc))

		return dev_err_probe(dev, PTR_ERR(priv->rstc),

				     "failed to get cpg reset");



	reset_control_deassert(priv->rstc);

	ret = reset_control_deassert(priv->rstc);

	if (ret)

		return dev_err_probe(dev, ret, "failed to deassert");



	pm_runtime_enable(dev);

	pm_runtime_get_sync(dev);