Commit 8ed716ca authored by Hou Wenlong's avatar Hou Wenlong Committed by Paolo Bonzini
Browse files

KVM: x86/mmu: Pass parameter flush as false in kvm_tdp_mmu_zap_collapsible_sptes() 



Since tlb flush has been done for legacy MMU before
kvm_tdp_mmu_zap_collapsible_sptes(), so the parameter flush
should be false for kvm_tdp_mmu_zap_collapsible_sptes().

Fixes: e2209710 ("KVM: x86/mmu: Skip rmap operations if rmaps not allocated")
Signed-off-by: default avatarHou Wenlong <houwenlong93@linux.alibaba.com>
Message-Id: <21453a1d2533afb6e59fb6c729af89e771ff2e76.1637140154.git.houwenlong93@linux.alibaba.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent c7785d85

arch/x86/kvm/mmu/mmu.c

+2 −2
Original line number Diff line number Diff line
@@ -5854,7 +5854,7 @@ static bool kvm_mmu_zap_collapsible_spte(struct kvm *kvm, 
void kvm_mmu_zap_collapsible_sptes(struct kvm *kvm,

				   const struct kvm_memory_slot *slot)

{

	bool flush = false;

	bool flush;



	if (kvm_memslots_have_rmaps(kvm)) {

		write_lock(&kvm->mmu_lock);
@@ -5871,7 +5871,7 @@ void kvm_mmu_zap_collapsible_sptes(struct kvm *kvm, 


	if (is_tdp_mmu_enabled(kvm)) {

		read_lock(&kvm->mmu_lock);

		flush = kvm_tdp_mmu_zap_collapsible_sptes(kvm, slot, flush);

		flush = kvm_tdp_mmu_zap_collapsible_sptes(kvm, slot, false);

		if (flush)

			kvm_arch_flush_remote_tlbs_memslot(kvm, slot);

		read_unlock(&kvm->mmu_lock);