Commit 8ed19471 authored by Mark Bloch's avatar Mark Bloch Committed by Saeed Mahameed
Browse files

net/mlx5: Lag, Don't rescan if the device is going down 



If MLX5_PRIV_FLAGS_DISABLE_ALL_ADEV is set it means the device is going
down and mlx5_rescan_drivers_locked() shouldn't be called.
With this patch and the previous one in the series, unbinding a PCI
function when its netdev is part of a bond works and leaves the system in a
working state.

Signed-off-by: default avatarMark Bloch <mbloch@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 8c22ad36

drivers/net/ethernet/mellanox/mlx5/core/lag.c

+8 −2
Original line number Diff line number Diff line
@@ -258,6 +258,10 @@ static void mlx5_lag_add_devices(struct mlx5_lag *ldev) 
		if (!ldev->pf[i].dev)

			continue;



		if (ldev->pf[i].dev->priv.flags &

		    MLX5_PRIV_FLAGS_DISABLE_ALL_ADEV)

			continue;



		ldev->pf[i].dev->priv.flags &= ~MLX5_PRIV_FLAGS_DISABLE_IB_ADEV;

		mlx5_rescan_drivers_locked(ldev->pf[i].dev);

	}
@@ -286,8 +290,10 @@ static void mlx5_disable_lag(struct mlx5_lag *ldev) 
	roce_lag = __mlx5_lag_is_roce(ldev);



	if (roce_lag) {

		if (!(dev0->priv.flags & MLX5_PRIV_FLAGS_DISABLE_ALL_ADEV)) {

			dev0->priv.flags |= MLX5_PRIV_FLAGS_DISABLE_IB_ADEV;

			mlx5_rescan_drivers_locked(dev0);

		}

		mlx5_nic_vport_disable_roce(dev1);

	}