Commit 8e8d4364 authored by John Garry's avatar John Garry Committed by Martin K. Petersen
Browse files

scsi: libsas: Make sas_{alloc, alloc_slow, free}_task() private 



We have no users outside libsas any longer, so make sas_alloc_task(),
sas_alloc_slow_task(), and sas_free_task() private.

Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Link: https://lore.kernel.org/r/1665998435-199946-8-git-send-email-john.garry@huawei.com


Tested-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Tested-by: Niklas Cassel <niklas.cassel@wdc.com> # pm80xx
Reviewed-by: default avatarJason Yan <yanaijie@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 811be570

drivers/scsi/libsas/sas_init.c

+0 −3
Original line number Diff line number Diff line
@@ -35,7 +35,6 @@ struct sas_task *sas_alloc_task(gfp_t flags) 


	return task;

}

EXPORT_SYMBOL_GPL(sas_alloc_task);



struct sas_task *sas_alloc_slow_task(gfp_t flags)

{
@@ -56,7 +55,6 @@ struct sas_task *sas_alloc_slow_task(gfp_t flags) 


	return task;

}

EXPORT_SYMBOL_GPL(sas_alloc_slow_task);



void sas_free_task(struct sas_task *task)

{
@@ -65,7 +63,6 @@ void sas_free_task(struct sas_task *task) 
		kmem_cache_free(sas_task_cache, task);

	}

}

EXPORT_SYMBOL_GPL(sas_free_task);



/*------------ SAS addr hash -----------*/

void sas_hash_addr(u8 *hashed, const u8 *sas_addr)

drivers/scsi/libsas/sas_internal.h

+4 −0
Original line number Diff line number Diff line
@@ -52,6 +52,10 @@ void sas_unregister_phys(struct sas_ha_struct *sas_ha); 
struct asd_sas_event *sas_alloc_event(struct asd_sas_phy *phy, gfp_t gfp_flags);

void sas_free_event(struct asd_sas_event *event);



struct sas_task *sas_alloc_task(gfp_t flags);

struct sas_task *sas_alloc_slow_task(gfp_t flags);

void sas_free_task(struct sas_task *task);



int  sas_register_ports(struct sas_ha_struct *sas_ha);

void sas_unregister_ports(struct sas_ha_struct *sas_ha);

include/scsi/libsas.h

+0 −4
Original line number Diff line number Diff line
@@ -639,10 +639,6 @@ struct sas_task_slow { 
#define SAS_TASK_STATE_ABORTED      4

#define SAS_TASK_NEED_DEV_RESET     8



extern struct sas_task *sas_alloc_task(gfp_t flags);

extern struct sas_task *sas_alloc_slow_task(gfp_t flags);

extern void sas_free_task(struct sas_task *task);



static inline bool sas_is_internal_abort(struct sas_task *task)

{

	return task->task_proto == SAS_PROTOCOL_INTERNAL_ABORT;