Commit 8e4052c3 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jakub Kicinski
Browse files

net: dsa: b53: fix an off by one in checking "vlan->vid" 



The > comparison should be >= to prevent accessing one element beyond
the end of the dev->vlans[] array in the caller function, b53_vlan_add().
The "dev->vlans" array is allocated in the b53_switch_init() function
and it has "dev->num_vlans" elements.

Fixes: a2482d2c ("net: dsa: b53: Plug in VLAN support")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/YAbxI97Dl/pmBy5V@mwanda


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b160c285

drivers/net/dsa/b53/b53_common.c

+1 −1
Original line number Diff line number Diff line
@@ -1404,7 +1404,7 @@ int b53_vlan_prepare(struct dsa_switch *ds, int port, 
	    !(vlan->flags & BRIDGE_VLAN_INFO_UNTAGGED))

		return -EINVAL;



	if (vlan->vid_end > dev->num_vlans)

	if (vlan->vid_end >= dev->num_vlans)

		return -ERANGE;



	b53_enable_vlan(dev, true, ds->vlan_filtering);