Commit 8e1ed28f authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller
Browse files

genetlink: use parsed attrs in dumppolicy 



Attributes are already parsed based on the policy specified
in the family and ready-to-use in info->attrs. No need to
call genlmsg_parse() again.

Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Reviewed-by: default avatarJohannes Berg <johannes@sipsolutions.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7c1e0926

net/netlink/genetlink.c

+2 −7
Original line number Diff line number Diff line
@@ -1117,18 +1117,13 @@ struct ctrl_dump_policy_ctx { 


static int ctrl_dumppolicy_start(struct netlink_callback *cb)

{

	const struct genl_dumpit_info *info = genl_dumpit_info(cb);

	struct ctrl_dump_policy_ctx *ctx = (void *)cb->ctx;

	struct nlattr *tb[CTRL_ATTR_MAX + 1];

	struct nlattr **tb = info->attrs;

	const struct genl_family *rt;

	int err;



	BUILD_BUG_ON(sizeof(*ctx) > sizeof(cb->ctx));



	err = genlmsg_parse(cb->nlh, &genl_ctrl, tb, genl_ctrl.maxattr,

			    genl_ctrl.policy, cb->extack);

	if (err)

		return err;



	if (!tb[CTRL_ATTR_FAMILY_ID] && !tb[CTRL_ATTR_FAMILY_NAME])

		return -EINVAL;