Commit 8e1034a5 authored by Jan Beulich's avatar Jan Beulich Committed by Juergen Gross
Browse files

xen/pci-swiotlb: reduce visibility of symbols 



xen_swiotlb and pci_xen_swiotlb_init() are only used within the file
defining them, so make them static and remove the stubs. Otoh
pci_xen_swiotlb_detect() has a use (as function pointer) from the main
pci-swiotlb.c file - convert its stub to a #define to NULL.

Signed-off-by: default avatarJan Beulich <jbeulich@suse.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>

Link: https://lore.kernel.org/r/aef5fc33-9c02-4df0-906a-5c813142e13c@suse.com


Signed-off-by: default avatarJuergen Gross <jgross@suse.com>
parent e243ae95

arch/x86/include/asm/xen/swiotlb-xen.h

+1 −5
Original line number Diff line number Diff line
@@ -3,14 +3,10 @@ 
#define _ASM_X86_SWIOTLB_XEN_H



#ifdef CONFIG_SWIOTLB_XEN

extern int xen_swiotlb;

extern int __init pci_xen_swiotlb_detect(void);

extern void __init pci_xen_swiotlb_init(void);

extern int pci_xen_swiotlb_init_late(void);

#else

#define xen_swiotlb (0)

static inline int __init pci_xen_swiotlb_detect(void) { return 0; }

static inline void __init pci_xen_swiotlb_init(void) { }

#define pci_xen_swiotlb_detect NULL

static inline int pci_xen_swiotlb_init_late(void) { return -ENXIO; }

#endif

arch/x86/xen/pci-swiotlb-xen.c

+2 −2
Original line number Diff line number Diff line
@@ -18,7 +18,7 @@ 
#endif

#include <linux/export.h>



int xen_swiotlb __read_mostly;

static int xen_swiotlb __read_mostly;



/*

 * pci_xen_swiotlb_detect - set xen_swiotlb to 1 if necessary
@@ -56,7 +56,7 @@ int __init pci_xen_swiotlb_detect(void) 
	return xen_swiotlb;

}



void __init pci_xen_swiotlb_init(void)

static void __init pci_xen_swiotlb_init(void)

{

	if (xen_swiotlb) {

		xen_swiotlb_init_early();