Commit 8dc879a1 authored Dec 30, 2020 by Zheng Yongjun Committed by David S. Miller Jan 05, 2021

net: kcm: Replace fput with sockfd_put



The function sockfd_lookup uses fget on the value that is stored in
the file field of the returned structure, so fput should ultimately be
applied to this value.  This can be done directly, but it seems better
to use the specific macro sockfd_put, which does the same thing.

Perform a source code refactoring by using the following semantic patch.

    // <smpl>
    @@
    expression s;
    @@

       s = sockfd_lookup(...)
       ...
    + sockfd_put(s);
    - fput(s->file);
    // </smpl>

Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8407b231

net/kcm/kcmsock.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1496,7 +1496,7 @@ static int kcm_attach_ioctl(struct socket sock, struct kcm_attach info)

		return 0;
		out:
		fput(csock->file);
		sockfd_put(csock);
		return err;
		}

		@@ -1644,7 +1644,7 @@ static int kcm_unattach_ioctl(struct socket sock, struct kcm_unattach info)
		spin_unlock_bh(&mux->lock);

		out:
		fput(csock->file);
		sockfd_put(csock);
		return err;
		}