Commit 8db8be9c authored by Benjamin Tissoires's avatar Benjamin Tissoires Committed by Jiri Kosina
Browse files

HID: input: fix uclogic tablets 



commit 87562fcd ("HID: input: remove the need for HID_QUIRK_INVERT")
made the assumption that it was the only one handling tablets and thus
kept an internal state regarding the tool.

Turns out that the uclogic driver has a timer to release the in range
bit, effectively making hid-input ignoring all in range information
after the very first one.

Fix that by having a more rationale approach which consists in forwarding
every event and let the input stack filter out the duplicates.

Reported-by: default avatarStefan Hansson <newbie13xd@gmail.com>
Fixes: 87562fcd ("HID: input: remove the need for HID_QUIRK_INVERT")
Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 750ec977

drivers/hid/hid-input.c

+4 −1
Original line number Diff line number Diff line
@@ -1534,7 +1534,10 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct 
			 * assume ours

			 */

			if (!report->tool)

				hid_report_set_tool(report, input, usage->code);

				report->tool = usage->code;



			/* drivers may have changed the value behind our back, resend it */

			hid_report_set_tool(report, input, report->tool);

		} else {

			hid_report_release_tool(report, input, usage->code);

		}