Commit 8db1b8eb authored by Yury Norov's avatar Yury Norov Committed by Yang Yingliang
Browse files

thread: move thread bits accessors to separated file 



hulk inclusion
category: feature
bugzilla: NA
CVE: NA
---------------------------

Thread bits may be accessed from low-level code, so isolating is a measure
to avoid circular dependencies in header files.

The exact reason for circular dependency is WARN_ON() macro added in patch
edd63a27 "set_restore_sigmask() is never called without SIGPENDING (and
never should be)"

Signed-off-by: default avatarYury Norov <ynorov@caviumnetworks.com>
Signed-off-by: default avatarXiongfeng Wang <wangxiongfeng2@huawei.com>
Reviewed-by: default avatarHanjun Guo &lt;guohanjun@huawei.com <mailto:guohanjun@huawei.com&gt;>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
parent 0ce25f3c

include/linux/sched.h

+1 −0
Original line number Diff line number Diff line
@@ -28,6 +28,7 @@ 
#include <linux/mm_types_task.h>

#include <linux/task_io_accounting.h>

#include <linux/rseq.h>

#include <linux/thread_bits.h>



/* task_struct member predeclarations (sorted alphabetically): */

struct audit_context;

include/linux/thread_bits.h

0 → 100644
+87 −0
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0+ */



/* Common low-level thread bits accessors */



#ifndef _LINUX_THREAD_BITS_H

#define _LINUX_THREAD_BITS_H



#ifndef __ASSEMBLY__



/*

 * For per-arch arch_within_stack_frames() implementations, defined in

 * asm/thread_info.h.

 */

enum {

	BAD_STACK = -1,

	NOT_STACK = 0,

	GOOD_FRAME,

	GOOD_STACK,

};



#include <linux/bitops.h>

#include <asm/thread_info.h>



#ifdef CONFIG_THREAD_INFO_IN_TASK

/*

 * For CONFIG_THREAD_INFO_IN_TASK kernels we need <asm/current.h> for the

 * definition of current, but for !CONFIG_THREAD_INFO_IN_TASK kernels,

 * including <asm/current.h> can cause a circular dependency on some platforms.

 */

#include <asm/current.h>

#define current_thread_info() ((struct thread_info *)current)

#endif



/*

 * flag set/clear/test wrappers

 * - pass TIF_xxxx constants to these functions

 */



static inline void set_ti_thread_flag(struct thread_info *ti, int flag)

{

	set_bit(flag, (unsigned long *)&ti->flags);

}



static inline void clear_ti_thread_flag(struct thread_info *ti, int flag)

{

	clear_bit(flag, (unsigned long *)&ti->flags);

}



static inline void update_ti_thread_flag(struct thread_info *ti, int flag,

					 bool value)

{

	if (value)

		set_ti_thread_flag(ti, flag);

	else

		clear_ti_thread_flag(ti, flag);

}



static inline int test_and_set_ti_thread_flag(struct thread_info *ti, int flag)

{

	return test_and_set_bit(flag, (unsigned long *)&ti->flags);

}



static inline int test_and_clear_ti_thread_flag(struct thread_info *ti, int flag)

{

	return test_and_clear_bit(flag, (unsigned long *)&ti->flags);

}



static inline int test_ti_thread_flag(struct thread_info *ti, int flag)

{

	return test_bit(flag, (unsigned long *)&ti->flags);

}



#define set_thread_flag(flag) \

	set_ti_thread_flag(current_thread_info(), flag)

#define clear_thread_flag(flag) \

	clear_ti_thread_flag(current_thread_info(), flag)

#define update_thread_flag(flag, value) \

	update_ti_thread_flag(current_thread_info(), flag, value)

#define test_and_set_thread_flag(flag) \

	test_and_set_ti_thread_flag(current_thread_info(), flag)

#define test_and_clear_thread_flag(flag) \

	test_and_clear_ti_thread_flag(current_thread_info(), flag)

#define test_thread_flag(flag) \

	test_ti_thread_flag(current_thread_info(), flag)



#endif /* !__ASSEMBLY__ */

#endif /* _LINUX_THREAD_BITS_H */

include/linux/thread_info.h

+1 −74
Original line number Diff line number Diff line
@@ -11,30 +11,9 @@ 
#include <linux/types.h>

#include <linux/bug.h>

#include <linux/restart_block.h>



#ifdef CONFIG_THREAD_INFO_IN_TASK

/*

 * For CONFIG_THREAD_INFO_IN_TASK kernels we need <asm/current.h> for the

 * definition of current, but for !CONFIG_THREAD_INFO_IN_TASK kernels,

 * including <asm/current.h> can cause a circular dependency on some platforms.

 */

#include <asm/current.h>

#define current_thread_info() ((struct thread_info *)current)

#endif

#include <linux/thread_bits.h>



#include <linux/bitops.h>



/*

 * For per-arch arch_within_stack_frames() implementations, defined in

 * asm/thread_info.h.

 */

enum {

	BAD_STACK = -1,

	NOT_STACK = 0,

	GOOD_FRAME,

	GOOD_STACK,

};



#include <asm/thread_info.h>



#ifdef __KERNEL__
@@ -45,58 +24,6 @@ enum { 


#define THREADINFO_GFP		(GFP_KERNEL_ACCOUNT | __GFP_ZERO)



/*

 * flag set/clear/test wrappers

 * - pass TIF_xxxx constants to these functions

 */



static inline void set_ti_thread_flag(struct thread_info *ti, int flag)

{

	set_bit(flag, (unsigned long *)&ti->flags);

}



static inline void clear_ti_thread_flag(struct thread_info *ti, int flag)

{

	clear_bit(flag, (unsigned long *)&ti->flags);

}



static inline void update_ti_thread_flag(struct thread_info *ti, int flag,

					 bool value)

{

	if (value)

		set_ti_thread_flag(ti, flag);

	else

		clear_ti_thread_flag(ti, flag);

}



static inline int test_and_set_ti_thread_flag(struct thread_info *ti, int flag)

{

	return test_and_set_bit(flag, (unsigned long *)&ti->flags);

}



static inline int test_and_clear_ti_thread_flag(struct thread_info *ti, int flag)

{

	return test_and_clear_bit(flag, (unsigned long *)&ti->flags);

}



static inline int test_ti_thread_flag(struct thread_info *ti, int flag)

{

	return test_bit(flag, (unsigned long *)&ti->flags);

}



#define set_thread_flag(flag) \

	set_ti_thread_flag(current_thread_info(), flag)

#define clear_thread_flag(flag) \

	clear_ti_thread_flag(current_thread_info(), flag)

#define update_thread_flag(flag, value) \

	update_ti_thread_flag(current_thread_info(), flag, value)

#define test_and_set_thread_flag(flag) \

	test_and_set_ti_thread_flag(current_thread_info(), flag)

#define test_and_clear_thread_flag(flag) \

	test_and_clear_ti_thread_flag(current_thread_info(), flag)

#define test_thread_flag(flag) \

	test_ti_thread_flag(current_thread_info(), flag)



#define tif_need_resched() test_thread_flag(TIF_NEED_RESCHED)



#ifndef CONFIG_HAVE_ARCH_WITHIN_STACK_FRAMES