Commit 8daf4e75 authored Mar 07, 2022 by Dan Carpenter Committed by Jakub Kicinski Mar 07, 2022

vxlan_core: delete unnecessary condition



The previous check handled the "if (!nh)" condition so we know "nh"
is non-NULL here.  Delete the check and pull the code in one tab.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
Reviewed-by: Roopa Prabhu <roopa@nvidia.com>
Link: https://lore.kernel.org/r/20220307125735.GC16710@kili


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 72f00505

drivers/net/vxlan/vxlan_core.c

+26 −28

Original line number	Diff line number	Diff line
		@@ -811,7 +811,6 @@ static int vxlan_fdb_nh_update(struct vxlan_dev vxlan, struct vxlan_fdb fdb,
		goto err_inval;
		}

		if (nh) {
		if (!nexthop_get(nh)) {
		NL_SET_ERR_MSG(extack, "Nexthop has been deleted");
		nh = NULL;
		@@ -843,7 +842,6 @@ static int vxlan_fdb_nh_update(struct vxlan_dev vxlan, struct vxlan_fdb fdb,
		goto err_inval;
		}
		}
		}

		if (old_nh) {
		list_del_rcu(&fdb->nh_list);