Commit 8d9fdb60 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jens Axboe
Browse files

ublk_drv: fix double shift bug 



The test/clear_bit() functions take a bit number, but this code is
passing as shifted value.  It's the equivalent of saying BIT(BIT(0))
instead of just BIT(0).

This doesn't affect runtime because numbers are small and it's done
consistently.

Fixes: fa362045 ("ublk: simplify ublk_ch_open and ublk_ch_release")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/Yt/2R/+MJf/MSoyl@kili


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 6d8c5afc

drivers/block/ublk_drv.c

+2 −2
Original line number Diff line number Diff line
@@ -127,8 +127,8 @@ struct ublk_device { 
	struct cdev		cdev;

	struct device		cdev_dev;



#define UB_STATE_OPEN		(1 << 0)

#define UB_STATE_USED		(1 << 1)

#define UB_STATE_OPEN		0

#define UB_STATE_USED		1

	unsigned long		state;

	int			ub_number;