Commit 8d86c8f6 authored by Borislav Petkov (AMD)'s avatar Borislav Petkov (AMD) Committed by Wentao Guan
Browse files

x86/microcode/AMD: Fix a -Wsometimes-uninitialized clang false positive 

stable inclusion
from stable-v6.6.81
commit 98a44622be2f193dc31bc542948407cac2bed9dc
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IBYZED

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=98a44622be2f193dc31bc542948407cac2bed9dc



--------------------------------

commit 5343558a868e7e635b40baa2e46bf53df1a2d131 upstream.

Initialize equiv_id in order to shut up:

  arch/x86/kernel/cpu/microcode/amd.c:714:6: warning: variable 'equiv_id' is \
  used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
        if (x86_family(bsp_cpuid_1_eax) < 0x17) {
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

because clang doesn't do interprocedural analysis for warnings to see
that this variable won't be used uninitialized.

Fixes: 94838d230a6c ("x86/microcode/AMD: Use the family,model,stepping encoded in the patch ID")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202407291815.gJBST0P3-lkp@intel.com/


Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 98a44622be2f193dc31bc542948407cac2bed9dc)
Signed-off-by: default avatarWentao Guan <guanwentao@uniontech.com>
parent 14cd6da5

arch/x86/kernel/cpu/microcode/amd.c

+1 −1
Original line number Diff line number Diff line
@@ -606,7 +606,7 @@ static void free_cache(void) 
static struct ucode_patch *find_patch(unsigned int cpu)

{

	struct ucode_cpu_info *uci = ucode_cpu_info + cpu;

	u16 equiv_id;

	u16 equiv_id = 0;



	equiv_id = find_equiv_id(&equiv_table, uci->cpu_sig.sig);

	if (!equiv_id)