Commit 8d783197 authored by Matt Johnston's avatar Matt Johnston Committed by David S. Miller
Browse files

mctp: Fix warnings reported by clang-analyzer 



net/mctp/device.c:140:11: warning: Assigned value is garbage or undefined
[clang-analyzer-core.uninitialized.Assign]
        mcb->idx = idx;

- Not a real problem due to how the callback runs, fix the warning.

net/mctp/route.c:458:4: warning: Value stored to 'msk' is never read
[clang-analyzer-deadcode.DeadStores]
        msk = container_of(key->sk, struct mctp_sock, sk);

- 'msk' dead assignment can be removed here.

Signed-off-by: default avatarMatt Johnston <matt@codeconstruct.com.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3185485c

net/mctp/device.c

+1 −1
Original line number Diff line number Diff line
@@ -120,7 +120,7 @@ static int mctp_dump_addrinfo(struct sk_buff *skb, struct netlink_callback *cb) 
	struct ifaddrmsg *hdr;

	struct mctp_dev *mdev;

	int ifindex;

	int idx, rc;

	int idx = 0, rc;



	hdr = nlmsg_data(cb->nlh);

	// filter by ifindex if requested

net/mctp/route.c

+0 −1
Original line number Diff line number Diff line
@@ -456,7 +456,6 @@ static int mctp_route_input(struct mctp_route *route, struct sk_buff *skb) 
		 * the reassembly/response key

		 */

		if (!rc && flags & MCTP_HDR_FLAG_EOM) {

			msk = container_of(key->sk, struct mctp_sock, sk);

			sock_queue_rcv_skb(key->sk, key->reasm_head);

			key->reasm_head = NULL;

			__mctp_key_done_in(key, net, f, MCTP_TRACE_KEY_REPLIED);