Commit 8d6e5e82 authored by Swapnil Sapkal's avatar Swapnil Sapkal Committed by Rafael J. Wysocki
Browse files

cpufreq: amd-pstate-ut: Remove module parameter access 



In amd-pstate-ut, shared memory-based systems call
get_shared_mem() as part of amd_pstate_ut_check_enabled()
function. This function was written when CONFIG_X86_AMD_PSTATE
was tristate config and amd_pstate can be built as a module.

Currently CONFIG_X86_AMD_PSTATE is a boolean config and module
parameter shared_mem is removed. But amd-pstate-ut code still
accesses this module parameter. Remove those accesses.

Fixes: 456ca88d ("cpufreq: amd-pstate: change amd-pstate driver to be built-in type")
Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Reviewed-by: default avatarMeng Li <li.meng@amd.com>
Reviewed-by: default avatarWyes Karny <wyes.karny@amd.com>
Suggested-by: default avatarWyes Karny <wyes.karny@amd.com>
Signed-off-by: default avatarSwapnil Sapkal <swapnil.sapkal@amd.com>
[ rjw: Subject edits ]
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent a436ae94

drivers/cpufreq/amd-pstate-ut.c

+2 −20
Original line number Diff line number Diff line
@@ -64,27 +64,9 @@ static struct amd_pstate_ut_struct amd_pstate_ut_cases[] = { 
static bool get_shared_mem(void)

{

	bool result = false;

	char path[] = "/sys/module/amd_pstate/parameters/shared_mem";

	char buf[5] = {0};

	struct file *filp = NULL;

	loff_t pos = 0;

	ssize_t ret;



	if (!boot_cpu_has(X86_FEATURE_CPPC)) {

		filp = filp_open(path, O_RDONLY, 0);

		if (IS_ERR(filp))

			pr_err("%s unable to open %s file!\n", __func__, path);

		else {

			ret = kernel_read(filp, &buf, sizeof(buf), &pos);

			if (ret < 0)

				pr_err("%s read %s file fail ret=%ld!\n",

					__func__, path, (long)ret);

			filp_close(filp, NULL);

		}



		if ('Y' == *buf)

	if (!boot_cpu_has(X86_FEATURE_CPPC))

		result = true;

	}



	return result;

}