Commit 8d2c9d25 authored by Jason Yan's avatar Jason Yan Committed by Martin K. Petersen
Browse files

scsi: libsas: Remove useless dev_list delete in sas_ex_discover_end_dev() 



The domain device 'child' is allocated in sas_ex_discover_end_dev() and
used to be added to the dev_list in this function. After the following two
fixes the device is added to the disco_list instead. As a result, the
list_del() and locking left behind is now redundant.

Fixes: 87c8331f ("[SCSI] libsas: prevent domain rediscovery competing with ata error handling")
Fixes: 92625f9b ("[SCSI] libsas: restore scan order")
Cc: John Garry <john.g.garry@oracle.com>
Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
Reviewed-by: default avatarJohn Garry <john.g.garry@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent ffebb38e

drivers/scsi/libsas/sas_expander.c

+0 −3
Original line number Diff line number Diff line
@@ -875,9 +875,6 @@ static struct domain_device *sas_ex_discover_end_dev( 
 out_list_del:

	sas_rphy_free(child->rphy);

	list_del(&child->disco_list_node);

	spin_lock_irq(&parent->port->dev_list_lock);

	list_del(&child->dev_list_node);

	spin_unlock_irq(&parent->port->dev_list_lock);

 out_free:

	sas_port_delete(phy->port);

 out_err: