Unverified Commit 8d1c4e59 authored by Paul Cercueil's avatar Paul Cercueil
Browse files

drm: tilcdc: Remove #ifdef guards for PM related functions 



Use the DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to handle
the .suspend/.resume callbacks.

These macros allow the suspend and resume functions to be automatically
dropped by the compiler when CONFIG_SUSPEND is disabled, without having
to use #ifdef guards.

This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.

Signed-off-by: default avatarPaul Cercueil <paul@crapouillou.net>
Acked-by: default avatarJyri Sarha <jyri.sarhaı@iki.fi>
Link: https://patchwork.freedesktop.org/patch/msgid/20221129191942.138244-8-paul@crapouillou.net
parent fcf23238

drivers/gpu/drm/tilcdc/tilcdc_drv.c

+3 −6
Original line number Original line Diff line number Diff line
@@ -496,7 +496,6 @@ static const struct drm_driver tilcdc_driver = { 
 * Power management:

 * Power management:

 */

 */





#ifdef CONFIG_PM_SLEEP

static int tilcdc_pm_suspend(struct device *dev)

static int tilcdc_pm_suspend(struct device *dev)

{

{

	struct drm_device *ddev = dev_get_drvdata(dev);

	struct drm_device *ddev = dev_get_drvdata(dev);
@@ -518,11 +517,9 @@ static int tilcdc_pm_resume(struct device *dev) 
	pinctrl_pm_select_default_state(dev);

	pinctrl_pm_select_default_state(dev);

	return  drm_mode_config_helper_resume(ddev);

	return  drm_mode_config_helper_resume(ddev);

}

}

#endif





static const struct dev_pm_ops tilcdc_pm_ops = {

static DEFINE_SIMPLE_DEV_PM_OPS(tilcdc_pm_ops,

	SET_SYSTEM_SLEEP_PM_OPS(tilcdc_pm_suspend, tilcdc_pm_resume)

				tilcdc_pm_suspend, tilcdc_pm_resume);

};





/*

/*

 * Platform driver:

 * Platform driver:
@@ -597,7 +594,7 @@ static struct platform_driver tilcdc_platform_driver = { 
	.remove     = tilcdc_pdev_remove,

	.remove     = tilcdc_pdev_remove,

	.driver     = {

	.driver     = {

		.name   = "tilcdc",

		.name   = "tilcdc",

		.pm     = &tilcdc_pm_ops,

		.pm     = pm_sleep_ptr(&tilcdc_pm_ops),

		.of_match_table = tilcdc_of_match,

		.of_match_table = tilcdc_of_match,

	},

	},

};

};