Commit 8d0caeed authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Ulf Hansson
Browse files

mmc: sdhci-spear: fix deferred probing 



The driver overrides the error codes and IRQ0 returned by platform_get_irq()
to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the error
codes upstream.  Since commit ce753ad1 ("platform: finally disallow IRQ0
in platform_get_irq() and its ilk") IRQ0 is no longer returned by those APIs,
so we now can safely ignore it...

Fixes: 682798a5 ("mmc: sdhci-spear: Handle return value of platform_get_irq")
Cc: stable@vger.kernel.org # v5.19+
Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Acked-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20230617203622.6812-10-s.shtylyov@omp.ru


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent b465dea5

drivers/mmc/host/sdhci-spear.c

+2 −2
Original line number Diff line number Diff line
@@ -65,8 +65,8 @@ static int sdhci_probe(struct platform_device *pdev) 
	host->hw_name = "sdhci";

	host->ops = &sdhci_pltfm_ops;

	host->irq = platform_get_irq(pdev, 0);

	if (host->irq <= 0) {

		ret = -EINVAL;

	if (host->irq < 0) {

		ret = host->irq;

		goto err_host;

	}

	host->quirks = SDHCI_QUIRK_BROKEN_ADMA;