Commit 8d005269 authored by Eric W. Biederman's avatar Eric W. Biederman Committed by Kees Cook
Browse files

binfmt_flat: Drop vestiges of coredump support 



There is the briefest start of coredump support in binfmt_flat. It
is actually a pain to maintain as binfmt_flat is not built on most
architectures so it is easy to overlook.

Since the support does not do anything remove it.

Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
Reviewed-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
Acked-by: default avatarGreg Ungerer <gerg@linux-m68k.org>
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/87mtgh17li.fsf_-_@email.froward.int.ebiederm.org
parent 6045ab5f

fs/binfmt_flat.c

+0 −22
Original line number Original line Diff line number Diff line
@@ -37,7 +37,6 @@ 
#include <linux/flat.h>

#include <linux/flat.h>

#include <linux/uaccess.h>

#include <linux/uaccess.h>

#include <linux/vmalloc.h>

#include <linux/vmalloc.h>

#include <linux/coredump.h>





#include <asm/byteorder.h>

#include <asm/byteorder.h>

#include <asm/unaligned.h>

#include <asm/unaligned.h>
@@ -98,33 +97,12 @@ static int load_flat_shared_library(int id, struct lib_info *p); 
#endif

#endif





static int load_flat_binary(struct linux_binprm *);

static int load_flat_binary(struct linux_binprm *);

#ifdef CONFIG_COREDUMP

static int flat_core_dump(struct coredump_params *cprm);

#endif





static struct linux_binfmt flat_format = {

static struct linux_binfmt flat_format = {

	.module		= THIS_MODULE,

	.module		= THIS_MODULE,

	.load_binary	= load_flat_binary,

	.load_binary	= load_flat_binary,

#ifdef CONFIG_COREDUMP

	.core_dump	= flat_core_dump,

	.min_coredump	= PAGE_SIZE

#endif

};

};





/****************************************************************************/

/*

 * Routine writes a core dump image in the current directory.

 * Currently only a stub-function.

 */



#ifdef CONFIG_COREDUMP

static int flat_core_dump(struct coredump_params *cprm)

{

	pr_warn("Process %s:%d received signr %d and should have core dumped\n",

		current->comm, current->pid, cprm->siginfo->si_signo);

	return 1;

}

#endif





/****************************************************************************/

/****************************************************************************/

/*

/*