Commit 8ccac4ed authored by Shailend Chand's avatar Shailend Chand Committed by Jakub Kicinski
Browse files

gve: Fix GFP flags when allocing pages 



Use GFP_ATOMIC when allocating pages out of the hotpath,
continue to use GFP_KERNEL when allocating pages during setup.

GFP_KERNEL will allow blocking which allows it to succeed
more often in a low memory enviornment but in the hotpath we do
not want to allow the allocation to block.

Fixes: 9b8dd5e5 ("gve: DQO: Add RX path")
Signed-off-by: default avatarShailend Chand <shailend@google.com>
Signed-off-by: default avatarJeroen de Borst <jeroendb@google.com>
Link: https://lore.kernel.org/r/20220913000901.959546-1-jeroendb@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ae8ffba8

drivers/net/ethernet/google/gve/gve_rx_dqo.c

+1 −1
Original line number Diff line number Diff line
@@ -157,7 +157,7 @@ static int gve_alloc_page_dqo(struct gve_priv *priv, 
	int err;



	err = gve_alloc_page(priv, &priv->pdev->dev, &buf_state->page_info.page,

			     &buf_state->addr, DMA_FROM_DEVICE, GFP_KERNEL);

			     &buf_state->addr, DMA_FROM_DEVICE, GFP_ATOMIC);

	if (err)

		return err;