Commit 8cc5b032 authored by Carlos Llamas's avatar Carlos Llamas Committed by Arnd Bergmann
Browse files

binder: fix sender_euid type in uapi header 



The {pid,uid}_t fields of struct binder_transaction were recently
replaced to use kernel types in commit 169adc2b ("android/binder.h:
add linux/android/binder(fs).h to UAPI compile-test coverage").

However, using __kernel_uid_t here breaks backwards compatibility in
architectures using 16-bits for this type, since glibc and some others
still expect a 32-bit uid_t. Instead, let's use __kernel_uid32_t which
avoids this compatibility problem.

Fixes: 169adc2b ("android/binder.h: add linux/android/binder(fs).h to UAPI compile-test coverage")
Reported-by: default avatarChristopher Ferris <cferris@google.com>
Signed-off-by: default avatarCarlos Llamas <cmllamas@google.com>
Acked-by: default avatarTodd Kjos <tkjos@google.com>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent 3cbcff69

include/uapi/linux/android/binder.h

+1 −1
Original line number Diff line number Diff line
@@ -289,7 +289,7 @@ struct binder_transaction_data { 
	/* General information about the transaction. */

	__u32	        flags;

	__kernel_pid_t	sender_pid;

	__kernel_uid_t	sender_euid;

	__kernel_uid32_t	sender_euid;

	binder_size_t	data_size;	/* number of bytes of data */

	binder_size_t	offsets_size;	/* number of bytes of offsets */