Commit 8cb7ebe4 authored by Dafna Hirschfeld's avatar Dafna Hirschfeld Committed by Mauro Carvalho Chehab
Browse files

media: staging: rkisp1: isp: set metadata pads to MEDIA_BUS_FMT_METADATA_FIXED 



Set the code of the metadata pads of the isp entity to
MEDIA_BUS_FMT_METADATA_FIXED and set the width and
height of their formats to 0. This solves the TODO
item:
"Fix pad format size for statistics and parameters entities."

Signed-off-by: default avatarDafna Hirschfeld <dafna.hirschfeld@collabora.com>
Acked-by: default avatarHelen Koike <helen.koike@collabora.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 6ad253cc

drivers/staging/media/rkisp1/TODO

+0 −1
Original line number Diff line number Diff line 
* Fix pad format size for statistics and parameters entities.

* Fix checkpatch errors.



NOTES:

drivers/staging/media/rkisp1/rkisp1-isp.c

+4 −4
Original line number Diff line number Diff line
@@ -574,7 +574,7 @@ static int rkisp1_isp_enum_mbus_code(struct v4l2_subdev *sd, 
	} else {

		if (code->index > 0)

			return -EINVAL;

		code->code = MEDIA_BUS_FMT_FIXED;

		code->code = MEDIA_BUS_FMT_METADATA_FIXED;

		return 0;

	}
@@ -633,10 +633,10 @@ static int rkisp1_isp_init_config(struct v4l2_subdev *sd, 
					      RKISP1_ISP_PAD_SINK_PARAMS);

	src_fmt = v4l2_subdev_get_try_format(sd, cfg,

					     RKISP1_ISP_PAD_SOURCE_STATS);

	sink_fmt->width = RKISP1_DEFAULT_WIDTH;

	sink_fmt->height = RKISP1_DEFAULT_HEIGHT;

	sink_fmt->width = 0;

	sink_fmt->height = 0;

	sink_fmt->field = V4L2_FIELD_NONE;

	sink_fmt->code = MEDIA_BUS_FMT_FIXED;

	sink_fmt->code = MEDIA_BUS_FMT_METADATA_FIXED;

	*src_fmt = *sink_fmt;



	return 0;