Commit 8c9be1e5 authored Oct 27, 2020 by Harshad Shirwadkar Committed by Theodore Ts'o Oct 28, 2020

ext4: use IS_ERR() for error checking of path



With this fix, fast commit recovery code uses IS_ERR() for path
returned by ext4_find_extent.

Fixes: 8016e29f ("ext4: fast commit recovery path")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Link: https://lore.kernel.org/r/20201027204342.2794949-1-harshadshirwadkar@gmail.com


Signed-off-by: Theodore Ts'o <tytso@mit.edu>

parent b5b18160

fs/ext4/fast_commit.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -1616,8 +1616,10 @@ static int ext4_fc_replay_add_range(struct super_block *sb,
		if (ret == 0) {
		/* Range is not mapped */
		path = ext4_find_extent(inode, cur, NULL, 0);
		if (!path)
		continue;
		if (IS_ERR(path)) {
		iput(inode);
		return 0;
		}
		memset(&newex, 0, sizeof(newex));
		newex.ee_block = cpu_to_le32(cur);
		ext4_ext_store_pblock(