Commit 8c935dea authored Apr 23, 2020 by Fabrice Gasnier Committed by Felipe Balbi May 25, 2020

usb: dwc2: gadget: move gadget resume after the core is in L0 state



When the remote wakeup interrupt is triggered, lx_state is resumed from L2
to L0 state. But when the gadget resume is called, lx_state is still L2.
This prevents the resume callback to queue any request. Any attempt
to queue a request from resume callback will result in:
- "submit request only in active state" debug message to be issued
- dwc2_hsotg_ep_queue() returns -EAGAIN

Call the gadget resume routine after the core is in L0 state.

Fixes: f81f46e1 ("usb: dwc2: implement hibernation during bus suspend/resume")

Acked-by: Minas Harutyunyan <hminas@synopsys.com>
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>

parent 43cd0023

drivers/usb/dwc2/core_intr.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -416,10 +416,13 @@ static void dwc2_handle_wakeup_detected_intr(struct dwc2_hsotg *hsotg)
		if (ret && (ret != -ENOTSUPP))
		dev_err(hsotg->dev, "exit power_down failed\n");

		/* Change to L0 state */
		hsotg->lx_state = DWC2_L0;
		call_gadget(hsotg, resume);
		}
		} else {
		/* Change to L0 state */
		hsotg->lx_state = DWC2_L0;
		}
		} else {
		if (hsotg->params.power_down)
		return;