Commit 8c91c579 authored by Ritesh Harjani's avatar Ritesh Harjani Committed by Theodore Ts'o
Browse files

ext4: add extra check in ext4_mb_mark_bb() to prevent against possible corruption 



This patch adds an extra checks in ext4_mb_mark_bb() function
to make sure we mark & report error if we were to mark/clear any
of the critical FS metadata specific bitmaps (&bail out) to prevent
from any accidental corruption.

Suggested-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarRitesh Harjani <riteshh@linux.ibm.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/53cbb6f2573db162a57f935365050d8b1df202ee.1644992610.git.riteshh@linux.ibm.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent a00b482b

fs/ext4/mballoc.c

+8 −0
Original line number Diff line number Diff line
@@ -3918,6 +3918,14 @@ void ext4_mb_mark_bb(struct super_block *sb, ext4_fsblk_t block, 
			EXT4_BLOCKS_PER_GROUP(sb) - EXT4_C2B(sbi, blkoff));

		clen = EXT4_NUM_B2C(sbi, thisgrp_len);



		if (!ext4_sb_block_valid(sb, NULL, block, thisgrp_len)) {

			ext4_error(sb, "Marking blocks in system zone - "

				   "Block = %llu, len = %u",

				   block, thisgrp_len);

			bitmap_bh = NULL;

			break;

		}



		bitmap_bh = ext4_read_block_bitmap(sb, group);

		if (IS_ERR(bitmap_bh)) {

			err = PTR_ERR(bitmap_bh);