Unverified Commit 8c83a485 authored by Dan Carpenter's avatar Dan Carpenter Committed by Konstantin Komarov
Browse files

fs/ntfs3: Potential NULL dereference in hdr_find_split() 



The "e" pointer is dereferenced before it has been checked for NULL.
Move the dereference after the NULL check to prevent an Oops.

Fixes: 82cae269 ("fs/ntfs3: Add initialization of super block")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarKari Argillander <kari.argillander@gmail.com>
Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
parent 04810f00

fs/ntfs3/index.c

+2 −1
Original line number Diff line number Diff line
@@ -557,11 +557,12 @@ static const struct NTFS_DE *hdr_find_split(const struct INDEX_HDR *hdr) 
	size_t o;

	const struct NTFS_DE *e = hdr_first_de(hdr);

	u32 used_2 = le32_to_cpu(hdr->used) >> 1;

	u16 esize = le16_to_cpu(e->size);

	u16 esize;



	if (!e || de_is_last(e))

		return NULL;



	esize = le16_to_cpu(e->size);

	for (o = le32_to_cpu(hdr->de_off) + esize; o < used_2; o += esize) {

		const struct NTFS_DE *p = e;