Commit 8c6e8b09 authored by Biju Das's avatar Biju Das Committed by Greg Kroah-Hartman
Browse files

usb: host: xhci-plat: Improve clock handling in probe() 



It is always better to acquire all the clock resources first and
then do the clock operations.

This patch acquires all the optional clocks first and then calls
corresponding prepare_enable().

There is no functional change.

Signed-off-by: default avatarBiju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20230121145853.4792-8-biju.das.jz@bp.renesas.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3827fa1e

drivers/usb/host/xhci-plat.c

+5 −5
Original line number Diff line number Diff line
@@ -257,16 +257,16 @@ static int xhci_plat_probe(struct platform_device *pdev) 
		goto put_hcd;

	}



	ret = clk_prepare_enable(xhci->reg_clk);

	if (ret)

		goto put_hcd;



	xhci->clk = devm_clk_get_optional(&pdev->dev, NULL);

	if (IS_ERR(xhci->clk)) {

		ret = PTR_ERR(xhci->clk);

		goto disable_reg_clk;

		goto put_hcd;

	}



	ret = clk_prepare_enable(xhci->reg_clk);

	if (ret)

		goto put_hcd;



	ret = clk_prepare_enable(xhci->clk);

	if (ret)

		goto disable_reg_clk;