Commit 8c6ae461 authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by Jakub Kicinski
Browse files

net: dsa: lantiq_gswip: fix use after free in gswip_remove() 



of_node_put(priv->ds->slave_mii_bus->dev.of_node) should be
done before mdiobus_free(priv->ds->slave_mii_bus).

Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Fixes: 0d120dfb ("net: dsa: lantiq_gswip: don't use devres for mdiobus")
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/1644921768-26477-1-git-send-email-khoroshilov@ispras.ru


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 0b0dff5b

drivers/net/dsa/lantiq_gswip.c

+1 −1
Original line number Diff line number Diff line
@@ -2176,8 +2176,8 @@ static int gswip_remove(struct platform_device *pdev) 


	if (priv->ds->slave_mii_bus) {

		mdiobus_unregister(priv->ds->slave_mii_bus);

		mdiobus_free(priv->ds->slave_mii_bus);

		of_node_put(priv->ds->slave_mii_bus->dev.of_node);

		mdiobus_free(priv->ds->slave_mii_bus);

	}



	for (i = 0; i < priv->num_gphy_fw; i++)