Commit 8c647dd1 authored by Matthew Wilcox (Oracle)'s avatar Matthew Wilcox (Oracle) Committed by Linus Torvalds
Browse files

mm/swap: optimise get_shadow_from_swap_cache 

There's no need to get a reference to the page, just load the entry and
see if it's a shadow entry.

Link: https://lkml.kernel.org/r/20201112212641.27837-4-willy@infradead.org


Signed-off-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Cc: Dave Chinner <dchinner@redhat.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: William Kucharski <william.kucharski@oracle.com>
Cc: Yang Shi <yang.shi@linux.alibaba.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 96888e0a

mm/swap_state.c

+1 −3
Original line number Diff line number Diff line
@@ -87,11 +87,9 @@ void *get_shadow_from_swap_cache(swp_entry_t entry) 
	pgoff_t idx = swp_offset(entry);

	struct page *page;



	page = find_get_entry(address_space, idx);

	page = xa_load(&address_space->i_pages, idx);

	if (xa_is_value(page))

		return page;

	if (page)

		put_page(page);

	return NULL;

}