Unverified Commit 8c47ac2a authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Krzysztof Wilczyński
Browse files

PCI: mt7621: Convert to platform remove callback returning void 

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Link: https://lore.kernel.org/linux-pci/20230321193208.366561-12-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: default avatarSergio Paracuellos <sergio.paracuellos@gmail.com>
parent 22626c46

drivers/pci/controller/pcie-mt7621.c

+2 −4
Original line number Diff line number Diff line
@@ -524,15 +524,13 @@ static int mt7621_pcie_probe(struct platform_device *pdev) 
	return err;

}



static int mt7621_pcie_remove(struct platform_device *pdev)

static void mt7621_pcie_remove(struct platform_device *pdev)

{

	struct mt7621_pcie *pcie = platform_get_drvdata(pdev);

	struct mt7621_pcie_port *port;



	list_for_each_entry(port, &pcie->ports, list)

		reset_control_put(port->pcie_rst);



	return 0;

}



static const struct of_device_id mt7621_pcie_ids[] = {
@@ -543,7 +541,7 @@ MODULE_DEVICE_TABLE(of, mt7621_pcie_ids); 


static struct platform_driver mt7621_pcie_driver = {

	.probe = mt7621_pcie_probe,

	.remove = mt7621_pcie_remove,

	.remove_new = mt7621_pcie_remove,

	.driver = {

		.name = "mt7621-pci",

		.of_match_table = mt7621_pcie_ids,